Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documents for dependencies on macos #109

Merged
merged 10 commits into from
Sep 26, 2022
Merged

Documents for dependencies on macos #109

merged 10 commits into from
Sep 26, 2022

Conversation

mio-19
Copy link
Contributor

@mio-19 mio-19 commented Jun 29, 2022

No description provided.

@mio-19
Copy link
Contributor Author

mio-19 commented Jun 29, 2022

This pr requires #110

@mio-19
Copy link
Contributor Author

mio-19 commented Jun 29, 2022

BeamMP-Server.zip
v3.0.1 built for Apple Silicon

@lionkor
Copy link
Member

lionkor commented Jun 29, 2022

Thank you very much for your contribution!

With your permission, I would merge the lionkor/commandline patch into commandline upstream, too.

I'll get someone with a MacOS device to test this, and then we'll merge it. So far the code looks good to me ;)

lionkor
lionkor reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@lionkor lionkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason you recommend to use gcc here? Latest clang shipped on MacOS should compile it just fine, considering its C++17. Is this just a preference, or to keep a consistent version?

@mio-19
Copy link
Contributor Author

mio-19 commented Jul 1, 2022 •
edited
Loading

Is this just a preference, or to keep a consistent version?

It is just a preference

@mio-19
Copy link
Contributor Author

mio-19 commented Jul 1, 2022

With your permission, I would merge the lionkor/commandline patch into commandline upstream, too.

I opened a pr lionkor/commandline#24

@mio-19
Copy link
Contributor Author

mio-19 commented Jul 1, 2022

Is there any reason you recommend to use gcc here? Latest clang shipped on MacOS should compile it just fine, considering its C++17. Is this just a preference, or to keep a consistent version?

Actually it doesn't compile with gcc. I removed the section

@mio-19 mio-19 requested a review from lionkor July 8, 2022 05:20
@lionkor
Copy link
Member

lionkor commented Jul 8, 2022

On it, sorry for the long wait

lionkor
lionkor approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@lionkor lionkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lionkor lionkor merged commit fdf2481 into BeamMP:master Sep 26, 2022
lionkor pushed a commit that referenced this pull request Oct 22, 2022
@mio-19 @lionkor
document dependencies for macos (#109)
12a0ab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionkor lionkor lionkor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mio-19 @lionkor