-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Tags Feature to the BeamMP Server. #192
Conversation
TOML has arrays, so this should probably be an array:
|
Hi Lion, I have been thinking this one over over the last week and bit and I am thinking that though for us more technically capable people an array is the correct approach. BeamMP however is also used my people who are not as technically capable and I worry that a potential missing quote mark or comma in an array could cause the config to not be loaded and then raise new posts in support. Happy to hear other sides on this though. |
Fair enough, it's definitely a more complicated syntax as a TOML array. What bothers me about this approach is that it's an undocumented syntax, the parser for which will be in the backend. In this case, the comment should probably explain the syntax, something like "Separate tags with commas, like so: Tag1,Tag2,Tag3" or something. Other than that, maybe the team can decide on some good default tags, because I can't think of any. As for the windows compile error, that maybe a dependency issue, Anon might be able to help there. |
Yep, that is what I did on line 106 in src/TConfig.cpp.
Indeed.
Will do. @Anonymous-275 :P |
… on the server list.
8bf250e
to
8c73eb8
Compare
Needs better or no default tags |
Done. Changed the default to Freeroam to match the majority of servers presently on the list. |
Backend support for this is already implemented. |
Blocked by #227 |
This PR adds a tags functionality to the BeamMP server config and heartbeat.
The intended purpose of this is to enable better filtering on the server list based on keywords such as gamemode or roleplay.