Fix unicycle counting as car

[sla-ppy]

Fixes #246.

[sla-ppy]

This is a super dirty fix to the issue.
We essentially duct tape a problem which should definitely be revisited later on!

The reason for this dirty fix is because mVehichleData contains both unicycle and vehicle data, and I am unsure if we want it to stay like that.

I propose that in the new protocol we treat unicycle and vehicle data differently because there are questions to be answered like:

• Do we want to allow players to spawn multiple unicycles (as controllable props) or do we want to have a single one representing and acting as the player itself?
• Does it truly make sense to treat unicycles and vechicles differently?

Benefit of the proposal:

• Counting the unicycle and vehicle counts separately could be toyed around with further.
• Future wise the unicycle could have multiple models for players to have fun with.

[sla-ppy]

Please review my code: @lionkor.

[lionkor]

Thanks, logic looks sound and we obv saw it work.

[Starystars67]

Could I further this topic by suggesting that instead a configuration option be added to specify vehicle names that can be added so they bypass the vehicle limit.

This would be for things like the unicycle as default but can then be expanded to items like cones, bollards, concrete barriers or even pucks.

[lionkor]

Could I further this topic by suggesting that instead a configuration option be added to specify vehicle names that can be added so they bypass the vehicle limit.

This would be for things like the unicycle as default but can then be expanded to items like cones, bollards, concrete barriers or even pucks.

I would ask you to make a new feature issue for that, because I'd also like to specify that properly before building it, and I wouldn't want to tack it onto this bug as I want this in the next release.

[lionkor]

@sla-ppy btw in documentate unicycle dirty fix the correct form is document ;)

[lionkor]

looks good

[sla-ppy]

@sla-ppy btw in documentate unicycle dirty fix the correct form is document ;)