Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip migration test when transactions not avalible #50

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

jorants
Copy link
Contributor

@jorants jorants commented Jun 14, 2021

Addresses #43

Not every developer will have mongodb setup using mongos or as a replica set. This skips the failing test when the functionality is not available. I could not test whether it does run the test when it is available as I had to go of documentation, so please check this.

@roman-right
Copy link
Member

Good point, thank you.
I'll merge this guy in the evening.

@roman-right
Copy link
Member

Also, just to share how I do this, it is very comfortable to create a free atlas instance to do development things there
https://www.mongodb.com/cloud/atlas
You don't need mongodb (even dockers) on your own system n that case. I like it :-)

@roman-right roman-right merged commit 9d4a36d into BeanieODM:main Jun 14, 2021
@jorants jorants deleted the skip-migration-test branch June 15, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants