Fix: FindInterface type-hints break on View models #819
Conversation
GuyGooL5
changed the title
|
Hi @GuyGooL5 , |
|
Hi @roman-right, unfortunately I've found that my solution isn't all-inclusive and there are many edge cases, I'm drafting this PR and will work on it. |
|
Hi @GuyGooL5 , |
| @@ -1012,7 +1012,8 @@ def get_previous_changes(self) -> Dict[str, Any]: | |||
| return {} | |||
|
|
|||
| return self._collect_updates( | |||
| self._previous_saved_state, self._saved_state # type: ignore | |||
| self._previous_saved_state, | |||
| self._saved_state, # type: ignore | |||
There was a problem hiding this comment.
Note: this has nothing to do with the PR, it was simply auto-formatted.
|
@roman-right I hope that's enough for a fix. I tested the type inference in VSCode and it seems to work, is there maybe a test I can implement to future-proof it from a static-type checker's perspective? |
|
Hi @GuyGooL5 , |
|
Hi @GuyGooL5 , |
|
Great news, thanks. |
This PR adds a new TypeVar for
Viewjust likeDocType, and is used inFindInterfaceto bind it for each model with their respective model type.It fixes a bug where find operations type-checks break when used with
Viewdescendants. For example, see this issue.