Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: soft delete #901

Merged
merged 7 commits into from
May 1, 2024
Merged

Feature: soft delete #901

merged 7 commits into from
May 1, 2024

Conversation

alm0ra
Copy link
Contributor

@alm0ra alm0ra commented Mar 23, 2024

Fixes #534

in this PR i added new Document class with ability of soft delete

@alm0ra alm0ra changed the title Feat/soft delete Feature: soft delete Mar 23, 2024
@roman-right
Copy link
Member

Hi @alm0ra ,
Thank you for the PR. Could you please add tests for this?

@alm0ra
Copy link
Contributor Author

alm0ra commented Apr 17, 2024

@roman-right yes i can , but first i wanted to know is it ok to implement in this way? If it's ok i will add tests.

add DocumentWithSoftDelete to init beanie
add test insert one and delete one
@alm0ra
Copy link
Contributor Author

alm0ra commented Apr 19, 2024

@roman-right
i added tests.
can you review?

@roman-right roman-right merged commit 65c2190 into BeanieODM:main May 1, 2024
21 checks passed
@roman-right
Copy link
Member

Merged,
It will be published today.

@alm0ra could you please add a doc page for this when you have time?

@alm0ra
Copy link
Contributor Author

alm0ra commented May 1, 2024

@roman-right
Yeah , i will open a PR soon .

@jhamman
Copy link

jhamman commented May 14, 2024

This looks like a super cool feature. Are the docs in progress?

@alm0ra
Copy link
Contributor Author

alm0ra commented May 14, 2024

@jhamman
I haven't started it yet.
But it has open issue #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soft Delete
3 participants