Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in source code comment in inheritance.md #984

Merged

Conversation

fnogatz
Copy link
Contributor

@fnogatz fnogatz commented Jul 30, 2024

Typo can be seen online at https://beanie-odm.dev/tutorial/inheritance/:

image


The work on this PR was sponsored by SUSI&James GmbH.

@07pepa
Copy link
Member

07pepa commented Aug 1, 2024

hm this could help https://github.com/crate-ci/typos as well maybe you can add it as precomit?

@LawMixer LawMixer self-requested a review August 1, 2024 20:01
Copy link

@LawMixer LawMixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a non-breaking change to me, appreciate you making a pull request!

@fnogatz
Copy link
Contributor Author

fnogatz commented Aug 9, 2024

So all it takes to get merged is two additional approvers? 😄

Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@adeelsohailahmed adeelsohailahmed merged commit 0b8d50b into BeanieODM:main Aug 15, 2024
19 checks passed
@fnogatz fnogatz deleted the fix-typo-inheritance-md branch August 15, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants