Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex storing #989

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix regex storing #989

merged 1 commit into from
Aug 27, 2024

Conversation

07pepa
Copy link
Member

@07pepa 07pepa commented Aug 2, 2024 •
edited by adeelsohailahmed
Loading

Closes #983

@07pepa 07pepa force-pushed the fix-regex-storing branch 2 times, most recently from 45e3f26 to 70f7318 Compare August 2, 2024 18:16
@07pepa 07pepa marked this pull request as draft August 2, 2024 18:56
@07pepa 07pepa marked this pull request as ready for review August 2, 2024 19:13
@07pepa 07pepa force-pushed the fix-regex-storing branch 2 times, most recently from 03afa54 to 0b89481 Compare August 5, 2024 20:55
adeelsohailahmed
adeelsohailahmed requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title of the PR and make it more descriptive.

@07pepa 07pepa changed the title fix #983 Fix regex storing Aug 22, 2024
@07pepa
Copy link
Member Author

07pepa commented Aug 22, 2024

@adeelsohailahmed done

adeelsohailahmed
adeelsohailahmed approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@07pepa 07pepa merged commit ecd3397 into BeanieODM:main Aug 27, 2024
19 checks passed
@07pepa 07pepa deleted the fix-regex-storing branch August 27, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LawMixer LawMixer LawMixer approved these changes

@adeelsohailahmed adeelsohailahmed adeelsohailahmed approved these changes

@Riverfount Riverfount Riverfount approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No support for Regex elements
4 participants
@07pepa @Riverfount @adeelsohailahmed @LawMixer