-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation in the readme extended #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome contribution! Most of my comments regard the style and conciseness of the README. I'm not familiar with iOS development, so any further suggestions or talk about my comments is greatly appreciated.
@Bear-03 thanks for your pr review. Last unresolved comment is regarding the subsubsubsection "troubleshooting". Dispite this - the pr is ready to review again |
@Flocksserver I've added some more comments. Please note that one of those comments continues the conversation about the iOS static libraries, so I've marked it as unresolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome changes! I absolutely love the way you went about reorganizing all the sections. Everything is far more clear now and these changes will definitely make it easier to expand the documentation in the future.
…tatic or dynamic libs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for all the hard work!
Add compile steps for static libraries (iOS) and execution hints to the README file