Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation in the readme extended #6

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

Flocksserver
Copy link

Add compile steps for static libraries (iOS) and execution hints to the README file

Copy link
Owner

@Bear-03 Bear-03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution! Most of my comments regard the style and conciseness of the README. I'm not familiar with iOS development, so any further suggestions or talk about my comments is greatly appreciated.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Flocksserver
Copy link
Author

@Bear-03 thanks for your pr review. Last unresolved comment is regarding the subsubsubsection "troubleshooting". Dispite this - the pr is ready to review again

README.md Outdated Show resolved Hide resolved
@Bear-03
Copy link
Owner

Bear-03 commented Feb 17, 2023

@Flocksserver I've added some more comments. Please note that one of those comments continues the conversation about the iOS static libraries, so I've marked it as unresolved.

Copy link
Owner

@Bear-03 Bear-03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changes! I absolutely love the way you went about reorganizing all the sections. Everything is far more clear now and these changes will definitely make it easier to expand the documentation in the future.

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@Bear-03 Bear-03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for all the hard work!

@Bear-03 Bear-03 merged commit ca9dc6e into Bear-03:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants