-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve code extract to be consistent #1137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotbadger
reviewed
Jul 24, 2023
cfabianski
force-pushed
the
fix/update-cli-line-report
branch
from
July 24, 2023 09:34
a75cbad
to
c12c3b6
Compare
cfabianski
force-pushed
the
fix/update-cli-line-report
branch
from
July 24, 2023 09:37
c12c3b6
to
ed2f03f
Compare
cfabianski
force-pushed
the
fix/update-cli-line-report
branch
from
July 24, 2023 15:21
1520efe
to
ccd5178
Compare
cfabianski
force-pushed
the
fix/update-cli-line-report
branch
2 times, most recently
from
July 24, 2023 15:32
cfadc8b
to
ea5d932
Compare
cfabianski
force-pushed
the
fix/update-cli-line-report
branch
from
July 24, 2023 15:37
ea5d932
to
26be552
Compare
gotbadger
reviewed
Jul 24, 2023
gotbadger
reviewed
Jul 24, 2023
gotbadger
reviewed
Jul 24, 2023
Co-authored-by: Philip Hayton <gotbadger@users.noreply.github.com>
Co-authored-by: Philip Hayton <gotbadger@users.noreply.github.com>
gotbadger
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code Extract is not consistent between CLI and Cloud because the CLI reads the lines from the file while the Cloud gets the info from the Source and Sink which may not be the entire line.
The new JSON field
code_extract
corrects that and makes it consistentAlso:
Tested with HTML, JSON and Table outputs
Still ToDo:
Related
Checklist