Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: saas file list #1188

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix: saas file list #1188

merged 1 commit into from
Aug 16, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Aug 15, 2023 •
edited
Loading

Description

Add the list of files to the detectors report and use this for the SaaS report.

The list of files was empty previously when cached data was used.

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe requested a review from gotbadger August 15, 2023 14:15
@didroe didroe force-pushed the fix/include-file-list-in-cached-data branch 2 times, most recently from 5b0b58a to f127951 Compare August 15, 2023 14:24
@didroe didroe changed the base branch from main to fix/exit-with-correct-code-in-sec-report August 15, 2023 14:43
@didroe didroe changed the title fix: security report exit code and saas file list fix: saas file list Aug 15, 2023
@didroe didroe force-pushed the fix/include-file-list-in-cached-data branch from f127951 to baeb96c Compare August 15, 2023 14:46
Base automatically changed from fix/exit-with-correct-code-in-sec-report to main August 15, 2023 15:36
@didroe didroe force-pushed the fix/include-file-list-in-cached-data branch from baeb96c to 667f1d7 Compare August 15, 2023 15:37
@didroe didroe requested a review from cfabianski August 16, 2023 14:10
@didroe didroe force-pushed the fix/include-file-list-in-cached-data branch from 667f1d7 to c883d01 Compare August 16, 2023 14:10
@didroe didroe merged commit 5073de8 into main Aug 16, 2023
5 checks passed
@didroe didroe deleted the fix/include-file-list-in-cached-data branch August 16, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

@gotbadger gotbadger Awaiting requested review from gotbadger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SaaS report sends empty file list if CLI scan is run with cache
2 participants
@didroe @cfabianski