Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nil client segfault #1258

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: nil client segfault #1258

merged 1 commit into from
Sep 12, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Sep 12, 2023 •
edited
Loading

Description

Be smarter when setting report.SendToCloud flag so that it's only true when we actually have a Cloud client

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet merged commit 011f6b8 into main Sep 12, 2023
9 checks passed
@elsapet elsapet deleted the fix/nil-client-segfault branch September 12, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @gotbadger