Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display files counter for JS #1427

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: display files counter for JS #1427

merged 1 commit into from
Dec 12, 2023

Conversation

cfabianski
Copy link
Collaborator

Description

fix #1426

Because JavaScript is a bit specific (in the way that we use the same detector), we were not counting the files detected as JSX or TSX.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@cfabianski cfabianski merged commit d853451 into main Dec 12, 2023
7 checks passed
@cfabianski cfabianski deleted the fix/display-counter-for-files-in-js branch December 12, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

@gotbadger gotbadger Awaiting requested review from gotbadger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

not finding/scanning all files
2 participants
@cfabianski @didroe