Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support binary OR for strings #1458

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: support binary OR for strings #1458

merged 1 commit into from
Jan 9, 2024

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Jan 9, 2024

Description

Add support for binary OR to the string detectors of applicable languages. This allows cursor scope detections to be found for an expression like foo || "some string".

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe requested a review from gotbadger January 9, 2024 10:48
@didroe didroe force-pushed the fix/support-binary-or-for-strings branch from c4d147c to 6f9468b Compare January 9, 2024 10:48
@didroe didroe merged commit e142a5d into main Jan 9, 2024
8 checks passed
@didroe didroe deleted the fix/support-binary-or-for-strings branch January 9, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CWE-798 (javascript_lang_hardcoded_secret) does not match on conditional assingment
2 participants
@didroe @gotbadger