Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractSymEntry Name Property #1868

Closed
Ethan-DeBandi99 opened this issue Oct 27, 2022 · 0 comments · Fixed by #1870
Closed

AbstractSymEntry Name Property #1868

Ethan-DeBandi99 opened this issue Oct 27, 2022 · 0 comments · Fixed by #1870
Assignees
@Ethan-DeBandi99
Labels
enhancement New feature or request In Progress Work on ticket is in progress / ticket is actively being worked

Comments

@Ethan-DeBandi99
Copy link
Contributor

CompositeSymEntries will usually return their component SymEntries for easy access from the client without additional messages. Each return adds a new entry for each component to the Symbol Table. Instead, we should track a name property in AbstractSymEntry that is set when addEntry is called. This way the entry is self aware of its name and can call attrib without adding a new entry each time.

Currently, only SegArray and GroupBy will require this update.
@Ethan-DeBandi99 Ethan-DeBandi99 added the enhancement New feature or request label Oct 27, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 self-assigned this Oct 27, 2022
This was referenced Oct 27, 2022
Closed
Merged
@Ethan-DeBandi99 Ethan-DeBandi99 added the In Progress Work on ticket is in progress / ticket is actively being worked label Oct 28, 2022
joshmarshall1 pushed a commit that referenced this issue Nov 1, 2022
@Ethan-DeBandi99
Closes #1868 - AbstractSymEntry Name Property (#1870)
f180965 
* Updates to store the symbol table name in the entry. Updated SegArray return to use the name instead of always adding to symbol table.

Updates for GroupBy to return component names.

* Removing old commented out code.

* Reorganizing So that lengths component is not always added to symbol table.

* Removing unused const.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ethan-DeBandi99 Ethan-DeBandi99

Labels
enhancement New feature or request In Progress Work on ticket is in progress / ticket is actively being worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #1868 - AbstractSymEntry Name Property Ethan-DeBandi99/arkouda
1 participant
@Ethan-DeBandi99