Closes #1787: Implement GroupBy.std() and GroupBy.var()
#1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stress-tess
requested review from
Ethan-DeBandi99,
reuster986,
mhmerrill and
joshmarshall1
stress-tess
force-pushed
the
1787_groupby_std
branch
from
ad11c03
to
ff9f53e
Compare
Ethan-DeBandi99
approved these changes
Sep 19, 2022
joshmarshall1
approved these changes
Sep 21, 2022
stress-tess
force-pushed
the
1787_groupby_std
branch
from
303840c
to
bc2e078
Compare
This PR (Closes Bears-R-Us#1787): - Adds `std` and `var` functionality to groupby aggregation - Updates `compare_keys` in `groupby_tests` to account for NAN values Note: We default `ddof=1` here to follow pandas, this differs from the default of `ddof=0` in `pdarrayclass` which follows numpy
stress-tess
force-pushed
the
1787_groupby_std
branch
from
bc2e078
to
743bd52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (Closes #1787):
stdandvarfunctionality to groupby aggregationcompare_keysingroupby_teststo account for NAN valuesNote:
We default
ddof=1here to follow pandas, this differs from the default ofddof=0inpdarrayclasswhich follows numpy