Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #1906 - HDF5 Assume pdarray/Strings Object when no ObjType Attribute #1907

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Closes #1906 - HDF5 Assume pdarray/Strings Object when no ObjType Attribute #1907

merged 4 commits into from
Nov 16, 2022

Conversation

Ethan-DeBandi99
Copy link
Contributor

Closes #1906

Updates the processing when reading HDF5 files to assume the object is pdarray or Strings when the ObjType attribute is not present. This allows for reading of HDF5 in the old format.

Removes the HDF5_Legacy module as it is no longer required to read these files.

Updates client load/read to remove the legacyHDF5 parameter since it is no longer used to read legacy files.

stress-tess
stress-tess approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good! We should also update references to legacyHDF5 in FILEIO.md, but other than that i think it's good to go

@Ethan-DeBandi99
Copy link
Contributor Author

Logic looks good! We should also update references to legacyHDF5 in FILEIO.md, but other than that i think it's good to go

Updated FILEIO.md

joshmarshall1
joshmarshall1 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@joshmarshall1 joshmarshall1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

jaketrookman
jaketrookman reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, maybe just add a new comment to the FILEIO.md

@stress-tess stress-tess merged commit f303006 into Bears-R-Us:master Nov 16, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 deleted the 1906_HFD5_not_objtype branch November 17, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketrookman jaketrookman jaketrookman left review comments

@stress-tess stress-tess stress-tess approved these changes

@joshmarshall1 joshmarshall1 joshmarshall1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HDF5 Assume pdarray/Strings Object when ObjectType not Set
4 participants
@Ethan-DeBandi99 @stress-tess @joshmarshall1 @jaketrookman