Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip idna utf-16 test to work around bug #2016

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

bmcdonald3
Copy link
Contributor

The UTF-16 IDNA test is causing a segfault that is not an obvious fix, so we are commenting that out for now to allow the CI to pass, but this will be revisited and fixed soon.

The UTF-16 IDNA test is causing a segfault that is not an obvious
fix, so we are commenting that out for now to allow the CI to pass,
but this will be revisited and fixed soon.
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine either way, but my suggestion will actually mark it skipped instead of passing.

tests/string_test.py Outdated Show resolved Hide resolved
tests/string_test.py Outdated Show resolved Hide resolved
@bmcdonald3 bmcdonald3 changed the title Comment out idna utf-16 test to work around bug Skip idna utf-16 test to work around bug Jan 4, 2023
@stress-tess stress-tess merged commit b5dedb9 into Bears-R-Us:master Jan 4, 2023
@bmcdonald3 bmcdonald3 deleted the idna-test branch January 4, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants