Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2038: Add percentage used to overmemlimit #2039

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Closes #2038: Add percentage used to overmemlimit #2039

merged 1 commit into from
Jan 10, 2023

Conversation

stress-tess
Copy link
Member

This PR (closes #2038) add percentage used to overmemlimit check

>>> ak.ones(1024 * 1024 * 1024)
array([1 1 1 ... 1 1 1])
>>> ak.get_mem_used(as_percent=True)
28

and the logs show

overMemLimit Line 254 INFO [Chapel] memory high watermark = 8589934592 memory limit = 30923764531 percentage used = 28%

Closes Bears-R-Us#2038: Add percentage used to overmemlimit
f454033 
This PR (closes Bears-R-Us#2038) add percentage used to `overmemlimit` check
jaketrookman
jaketrookman approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ethan-DeBandi99 Ethan-DeBandi99 merged commit 15b9993 into Bears-R-Us:master Jan 10, 2023
@stress-tess stress-tess deleted the 2038_add_percent_mem_used_overmemlimit branch February 22, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-DeBandi99 Ethan-DeBandi99 Ethan-DeBandi99 approved these changes

@joshmarshall1 joshmarshall1 joshmarshall1 approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add percentage of memory used to overmemlimit
4 participants
@stress-tess @Ethan-DeBandi99 @joshmarshall1 @jaketrookman