Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2042 - BigInt support in SegArray #2080

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Closes #2042 - BigInt support in SegArray #2080

merged 1 commit into from
Jan 26, 2023

Conversation

joshmarshall1
Copy link
Contributor

This PR closes #2042

Adds handling for BigInt types to SegmentedArray functions.
Adds test case for using BigInt in SegArray

Ethan-DeBandi99
Ethan-DeBandi99 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just ask that those 2 issues get created and linked before merging.

src/SegmentedMsg.chpl Show resolved Hide resolved
src/SegmentedMsg.chpl Show resolved Hide resolved
stress-tess
stress-tess approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

jaketrookman
jaketrookman approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@joshmarshall1 joshmarshall1 mentioned this pull request Jan 26, 2023
Closed
@joshmarshall1
Copy link
Contributor Author

Added Issue #2086 to handle the changes mentioned by @Ethan-DeBandi99

@Ethan-DeBandi99 Ethan-DeBandi99 merged commit fa4c587 into Bears-R-Us:master Jan 26, 2023
@stress-tess stress-tess mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-DeBandi99 Ethan-DeBandi99 Ethan-DeBandi99 approved these changes

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigint compatibility for segarray
4 participants
@joshmarshall1 @Ethan-DeBandi99 @stress-tess @jaketrookman