Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2341: Quiet 131 deprecations #2342

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

bmcdonald3
Copy link
Contributor

In order to stay up to date with the latest Chapel deprecations, rather than doing them all in the week prior to the release, compat modules are being added as deprecations come up, allowing for more deliberation regarding the impact of changes made for 2.0 stabilization.

This PR includes compatibility modules for the following deprecations:

  • bigint.pow: deprecated in favor of a standalone pow method
  • bigint.powMod: deprecated in favor of a standalone powMod method

Closes #2341

@bmcdonald3 bmcdonald3 marked this pull request as ready for review April 17, 2023 20:09
@bmcdonald3 bmcdonald3 force-pushed the quiet-131-deprecations branch 2 times, most recently from 0b56b99 to fd03c67 Compare April 18, 2023 12:36
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I definitely want @pierce314159 to get eyes on this before merging since he has primarily worked the bigint stuff.

@bmcdonald3
Copy link
Contributor Author

@Ethan-DeBandi99 OK, but just noting that these changes are limited to name changes and shouldn't have any impact on execution behavior or anything like that, this is just keeping Arkouda up to date with Chapel's main as things are deprecated, rather than filing one huge PR just before the release like we did in #2202.

@Ethan-DeBandi99 Ethan-DeBandi99 added this pull request to the merge queue Apr 25, 2023
Merged via the queue into Bears-R-Us:master with commit e4ac249 Apr 25, 2023
@bmcdonald3 bmcdonald3 deleted the quiet-131-deprecations branch April 26, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiet 1.31 deprecation warnings in real time
2 participants