Closes #2015 - Efficient NaN read from Parquet #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-DeBandi99
requested review from
stress-tess,
joshmarshall1 and
jaketrookman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2015
Previously Parquet read workflows for
floatanddoubletypes were updated to allow reading of NaN values. This update only read value by value, which is not the most efficient. This PR updates these workflows to read in batches and identify the NaN values using the definition level and a temporary array. Because we are able to read the data in chunks and then process/set the return, performance is improved. It is also worth noting that List columns (used for SegArrays) do not require a check of the Definition Level to set NaN values.The example runtimes below were run on a single locale with a DataFrame containing 2 columns, one with all NaN values and one with some NaN values. The DataFrame contained 10**8 rows.
Before this PR
After this PR