Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2471: ak.full() for Strings #2557

Merged
merged 6 commits into from
Jul 13, 2023
Merged

Closes #2471: ak.full() for Strings #2557

merged 6 commits into from
Jul 13, 2023

Conversation

TheOddCzar789
Copy link
Contributor

This PR (Closes #2471):

  • expands the existing ak.full() function to enable the creation of a Strings object of provided size that is filled with provided str
  • adds testing for creation of Strings object via ak.full()

Ethan-DeBandi99
Ethan-DeBandi99 suggested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good. I think we need to make one adjustment with the client function. I provided 2 suggestions, but I think I am leaning towards keeping the function name as is and removing the function from the __all__ because the usage is consistent with a private function.

arkouda/pdarraycreation.py Outdated Show resolved Hide resolved
tests/pdarray_creation_test.py Show resolved Hide resolved
stress-tess
stress-tess approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ethan stole all my comments, but i still found some stuff to talk about :)

Great job! I think this looks really good

arkouda/pdarraycreation.py Outdated Show resolved Hide resolved
arkouda/pdarraycreation.py Outdated Show resolved Hide resolved
arkouda/pdarraycreation.py Outdated Show resolved Hide resolved
arkouda/pdarraycreation.py Outdated Show resolved Hide resolved
tests/pdarray_creation_test.py Outdated Show resolved Hide resolved
stress-tess
stress-tess reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than forgetting to add the test that ethan suggested

tests/pdarray_creation_test.py Show resolved Hide resolved
Ethan-DeBandi99
Ethan-DeBandi99 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment added for informational purposes, so no changes needed unless you prefer the alternative. Looks good.

tests/pdarray_creation_test.py Outdated Show resolved Hide resolved
@stress-tess stress-tess added this pull request to the merge queue Jul 13, 2023
Merged via the queue into Bears-R-Us:master with commit 683695a Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketrookman jaketrookman jaketrookman approved these changes

@stress-tess stress-tess stress-tess approved these changes

@Ethan-DeBandi99 Ethan-DeBandi99 Ethan-DeBandi99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ak.full for Strings and append_single string segarray support
4 participants
@TheOddCzar789 @Ethan-DeBandi99 @stress-tess @jaketrookman