Closes #2573: pdarray_creation_test.py Conversion for new test framework
#2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOddCzar789
requested review from
Ethan-DeBandi99,
stress-tess and
jaketrookman
Ethan-DeBandi99
suggested changes
Jul 18, 2023
Ethan-DeBandi99
changed the title
pd_array_creation_test.py Conversion for new test framework
stress-tess
reviewed
Jul 31, 2023
TheOddCzar789
force-pushed
the
2573_pd_array_creation_test_conversion
branch
2 times, most recently
from
6e64a1d
to
ffbe6e9
Compare
|
Is this ready for rereview or is the commit history still messed up? |
|
@Ethan-DeBandi99 the commit history is no longer messed up. I'm not sure if it's ready for rereview, I think @TheOddCzar789 would need to weigh in on that |
stress-tess
requested changes
Aug 7, 2023
stress-tess
changed the title
pd_array_creation_test.py Conversion for new test frameworkpdarray_creation_test.py Conversion for new test framework
TheOddCzar789
force-pushed
the
2573_pd_array_creation_test_conversion
branch
from
ffbe6e9
to
d0dc12d
Compare
TheOddCzar789
force-pushed
the
2573_pd_array_creation_test_conversion
branch
from
d0dc12d
to
c4dbe99
Compare
TheOddCzar789
force-pushed
the
2573_pd_array_creation_test_conversion
branch
from
c4dbe99
to
e704897
Compare
stress-tess
reviewed
Aug 22, 2023
TheOddCzar789
force-pushed
the
2573_pd_array_creation_test_conversion
branch
from
8b21fd7
to
08cfc84
Compare
TheOddCzar789
force-pushed
the
2573_pd_array_creation_test_conversion
branch
from
08cfc84
to
ccc15a9
Compare
stress-tess
approved these changes
Aug 24, 2023
stress-tess
approved these changes
Aug 24, 2023
Ethan-DeBandi99
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (Closes #2573):
Converts file to new test framework by adding pytest. The changes were mostly (entirely?) syntactical, as I didn't see any obvious potential uses for parameterization.