Closed #2651: series_test.py conversion for new framework
#2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaketrookman
requested review from
hokiegeek2,
Ethan-DeBandi99,
stress-tess and
TheOddCzar789
TheOddCzar789
approved these changes
Aug 16, 2023
|
I added some updates to this, marking as a draft until those make it in |
Ethan-DeBandi99
suggested changes
Aug 18, 2023
jaketrookman
force-pushed
the
2651_series_new_test
branch
from
ff93492
to
648de5d
Compare
jaketrookman
commented
Aug 25, 2023
Ethan-DeBandi99
previously requested changes
Aug 28, 2023
jaketrookman
force-pushed
the
2651_series_new_test
branch
from
a5d8076
to
0165900
Compare
stress-tess
dismissed
Ethan-DeBandi99’s stale review
ethan's conversations have been resolved and he's moved on to another project
stress-tess
requested changes
Sep 1, 2023
TheOddCzar789
approved these changes
Sep 1, 2023
jaketrookman
requested review from
stress-tess,
Ethan-DeBandi99 and
TheOddCzar789
stress-tess
requested changes
Sep 4, 2023
TheOddCzar789
approved these changes
Sep 6, 2023
TheOddCzar789
approved these changes
Sep 6, 2023
stress-tess
reviewed
Sep 6, 2023
jaketrookman
force-pushed
the
2651_series_new_test
branch
from
bdc00a2
to
9189f6a
Compare
stress-tess
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (Closes #2651) updates
series_test.pyto the new testing framework.*This is just a direct conversion. I would appreciate some help identifying any places where some parameterization could be added.