Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2875: Clean up deprecations in advance of 1.33 release #2874

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Closes #2875: Clean up deprecations in advance of 1.33 release #2874

merged 6 commits into from
Dec 7, 2023

Conversation

bmcdonald3
Copy link
Contributor

@bmcdonald3 bmcdonald3 commented Dec 5, 2023 •
edited
Loading

Clean up deprecations for:

  • Shadowing of variables now triggers a warning
  • c_FILE deprecated in favor of c_ptr(c_FILE)
  • PCGRandomStream deprecated in favor of randomStream

Closes #2875

@bmcdonald3 bmcdonald3 changed the title Clean up deprecations in advance of 1.33 release Closes #2875: Clean up deprecations in advance of 1.33 release Dec 6, 2023
@bmcdonald3 bmcdonald3 marked this pull request as draft December 6, 2023 00:25
@bmcdonald3 bmcdonald3 marked this pull request as ready for review December 6, 2023 18:46
stress-tess
stress-tess approved these changes Dec 7, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
src/compat/gt-133/ArkoudaBigIntCompat.chpl Outdated Show resolved Hide resolved
jaketrookman
jaketrookman approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one fix Pierce suggested, Looks good

@stress-tess stress-tess added this pull request to the merge queue Dec 7, 2023
Merged via the queue into Bears-R-Us:master with commit 3fdde17 Dec 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketrookman jaketrookman jaketrookman approved these changes

@stress-tess stress-tess stress-tess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up deprecations in advance of 1.33 release
3 participants
@bmcdonald3 @stress-tess @jaketrookman