Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2949: Add compat modules for 1.34 #2950

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

bmcdonald3
Copy link
Contributor

Since the sort changes were added, Arkouda was failing to build with 1.33, as 1.33 and 1.34 were using the same compat modules. Splitting 1.34 off into it's own directory so that we can keep those changes separate.

Closes #2949

Since the sort changes were added, Arkouda was failing to build
with 1.33, as 1.33 and 1.34 were using the same compat modules.
Splitting 1.34 off into it's own directory so that we can keep
those changes separate.
@stress-tess stress-tess self-requested a review February 6, 2024 00:13
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@bmcdonald3 bmcdonald3 added this pull request to the merge queue Feb 6, 2024
Merged via the queue into Bears-R-Us:master with commit 3d25d12 Feb 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix 1.33 build issues after sort changes
2 participants