Closes #3071: Add permutation to our generators #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR (closes Bears-R-Us#3071) adds permutation to `rng`. The array version of the chpl `permute` proc requires idxType must be coercible from this stream’s eltType, so instead we use the domain version of `permute` and use that to gather the permuted vals. But we're not missing out on much because the array version seems to do the same thing but without aggregation
stress-tess
force-pushed
the
3071_rng_permutation
branch
from
8f45f07
to
fb80bd0
Compare
ajpotts
approved these changes
Apr 4, 2024
ajpotts
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (closes #3071) adds permutation to
rng.Note:
The array version of the chpl
permuteproc requires idxType must be coercible from this stream’s eltType, so instead we use the domain version ofpermuteand use that to gather the permuted vals. But we're not missing out on much because the array version seems to do the same thing but without aggregationI also added:
.cls-commands.jsonto.gitignorewhich is added by the chpl vscode extension_val_isinstance_of_unionto do anisinstancecheck on types inUnion