Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change module name to github.com/Bedrock-OSS/regolith #198

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

Unkn0wnCat
Copy link
Contributor

Hello everyone,

I've recently tried to install regolith using go install github.com/Bedrock-OSS/regolith, which didn't work as the module name was bedrock-oss.github.com/regolith. The old module name is sadly not importable from anywhere outside the project, including from go install as Go is looking for the source code using that URL.

This PR replaces the module name with the right one for the project: github.com/Bedrock-OSS/regolith

Hope this helps and looking forward to further contributing on this project,
Kevin

@SirLich
Copy link
Contributor

SirLich commented Sep 2, 2022

Thanks so much for the PR! I have to admit, I'm not entirely sure what this accomplishes, but that's probably due to my lack of Golang knowledge.

The 'normal' installation flow for Regolith would be via the MSI that we ship with each release.

Please feel free to get in touch on our Discord: https://discord.gg/XjV87YN

Otherwise, I will let the more knowledgeable people on the project review this :)

@stirante
Copy link
Member

stirante commented Sep 3, 2022

Afaik you need module name to match the repo url in order to make go automatically fetch the code and either install it as a library or compile and install it. I think it's a good change.

Copy link
Member

@Nusiq Nusiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't break anything so I have nothing against merging that.

@Nusiq Nusiq merged commit 330a113 into Bedrock-OSS:main Sep 3, 2022
@Nusiq
Copy link
Member

Nusiq commented Sep 3, 2022

The only problem with installation via go install github.com/Bedrock-OSS/regolith command is that it's the same as installing from source. We're setting the version number during the build process so when you install from source. You're getting the "development" version which means that the version check will always notify you that a newer version exists even though it's not true.

@Unkn0wnCat Unkn0wnCat deleted the update-module-name branch September 3, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants