Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hdel method to support deleting multiple hash fields #94

Merged
merged 5 commits into from
Jan 4, 2022

Conversation

asilgalis
Copy link
Contributor

Update hdel method to support deleting multiple hash fields.

Reference: redis command HDEL.

@omansour
Copy link
Contributor

test arent working :(
no ideas why ...

@asilgalis
Copy link
Contributor Author

I have just updated one method by enabling feature to reflect redis functionality which was not implemented.

Well it is very clear why tests are not working, you need to update your dependencies:

Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - Root composer.json requires atoum/atoum master-dev -> satisfiable by atoum/atoum[dev-master].
    - atoum/atoum dev-master requires php ^7.2 || ^8.0 -> your php version (7.1.27) does not satisfy that requirement.

Details (see https://travis-ci.org/github/M6Web/RedisMock/builds/745402043):

  • Job with php 7.1 will not work as you need to lock atoum/atoum to the version that requires php 7.1 and of course split to the separate branch something like 5.x (unless you don't want to continue support for older php versions) and tag with 5.0.1.
  • Jobs with php 7.2 and 7.3 will not work because atoum/atoum introduced breaking changes (namespaces have changed and more) but your library still depends on dev-master and tag with 6.0.0.

@asilgalis
Copy link
Contributor Author

Fixed broken namespaces and stuff

@lnahiro
Copy link
Contributor

lnahiro commented Jan 3, 2022

Hello @asilgalis,
can you rebase your branch with master ? i just updated to fix the ci. thank you

@asilgalis asilgalis requested a review from a team as a code owner January 3, 2022 18:26
@asilgalis asilgalis requested review from lnahiro and removed request for a team January 3, 2022 18:28
@lnahiro lnahiro merged commit 8884530 into BedrockStreaming:master Jan 4, 2022
@lnahiro
Copy link
Contributor

lnahiro commented Jan 4, 2022

Added in release : v5.1.0

@lnahiro lnahiro mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants