Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broadside cannon direction recognition #2695

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

DeltaFire15
Copy link
Contributor

@DeltaFire15 DeltaFire15 commented Jul 13, 2024

About The Pull Request

The proc deciding which broadside cannon to fire assumes things about the angle variable that aren't true.
This makes the proc more reliable, which makes the correct cannon fire all the time instead of only until angle goes above 360 or below 0.

Fixes #2648

Why It's Good For The Game

Fix man good.

Changelog

🆑
fix: Broadside cannons should now always fire on the correct side.
/:cl:

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the angle var was only 0-360, bleh

@Kenionatus
Copy link
Contributor

Should fix #2648 if it works.

@Bokkiewokkie Bokkiewokkie merged commit 5039f27 into BeeStation:master Aug 24, 2024
9 checks passed
@DeltaFire15 DeltaFire15 deleted the broadside-direction-fix branch September 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broadsides shooting only one side
3 participants