Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator/LockableColorPicker does not show correct RGB/HSV for output profile #3506

Closed
mmmtok opened this issue Nov 10, 2016 · 2 comments
Closed
Labels
patch provided type: bug Something is not doing what it's supposed to be doing

Comments

@mmmtok
Copy link

mmmtok commented Nov 10, 2016

Problem found in version 4.2.1184.

Reproduction procedure:

  1. Set preference to see histogram as output profile.
  2. Set some output profile
  3. See RGB/HSV values in navigator or lockable color picker
  4. Set another output profile
  5. See RGB/HSV values
  6. Compare values from step 3 and step 5. All seem to be sRGB values.

Candidate fix:

diff --git a/rtengine/iplab2rgb.cc b/rtengine/iplab2rgb.cc
index 6b04bb8..c6e5c3d 100644
--- a/rtengine/iplab2rgb.cc
+++ b/rtengine/iplab2rgb.cc
@@ -144,8 +144,6 @@ Image8* ImProcFunctions::lab2rgb (LabImage* lab, int cx, int cy, int cw, int ch,
 
     Image8* image = new Image8 (cw, ch);
     Glib::ustring profile;
-    cmsHPROFILE oprof = iccStore->getProfile (profile);
-
     bool standard_gamma;
 
     if(settings->HistogramWorking) {
@@ -159,6 +157,8 @@ Image8* ImProcFunctions::lab2rgb (LabImage* lab, int cx, int cy, int cw, int ch,
         standard_gamma = false;
     }
 
+    cmsHPROFILE oprof = iccStore->getProfile (profile);
+
     if (oprof) {
         cmsHPROFILE oprofG = oprof;
@Beep6581 Beep6581 added type: bug Something is not doing what it's supposed to be doing patch provided labels Nov 10, 2016
@Beep6581
Copy link
Owner

Beep6581 commented Nov 10, 2016

@Beep6581
Copy link
Owner

@Hombre57 can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch provided type: bug Something is not doing what it's supposed to be doing
Projects
None yet
Development

No branches or pull requests

3 participants