FIX: use sabre/dav instance from Dolibarr #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
One way to fix issue #53 is to use the Sabre/DAV library from Dolibarr. I quickly tested the CardDAV sync and it seems to work.
@jpfox Does the module use some of the newer APIs of Sabre/DAV or is the old Dolibarr version enough ? I would strongly advise to test thouroughly that everything works before merging this PR anyway.
Greetings.
Bonjour,
Une manière de résoudre l'issue #53 est d'utiliser la bibliothèque Sabre/DAV de Dolibarr. J'ai testé rapidement la synchro CardDAV et ça semble fonctionner.
@jpfox Est-ce que le module utilise des APIs récentes de Sabre/DAV ou bien la version de Dolibarr est-elle suffisante ? Quoi qu'il en soit, je vous recommanderais fortement de tester en profondeur que tout fonctionne bien avant de merger cette PR.