Image tags matching the upstream project #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bekt
commented
Sep 4, 2018
| echo "Upstream tags: $TAGS" | ||
|
|
||
| for t in ${TAGS}; do | ||
| docker build -t $HUB_REPO:ignore-$t --build-arg UPSTREAM_VERSION=$t . |
There was a problem hiding this comment.
ignore- will be removed after I get some validation this thing works.
Open
Bekt
force-pushed
the
tags
branch
4 times, most recently
from
9caef43
to
1c5e155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #7
This PR introduces building the image from a different upstream images (FROM). Since there's not a good way to subscribe to specific parent image tag builds, the
ci.shrebuilds images from all available upstream tags.The end result corresponds to the parent image, meaning this image's tags will be the same as gliderlabs/logspout tags. E.g
bekt/logspout-logstash:v3.2.5.A few ceveats:
build.shwas not introduced until v3 in the upstream project.build.shdoes not change between versions. A better way would be to download the rightbuild.shfile during build time for each version.I didn't put much thinking or work into this, just went with the fastest way. If there's a better way, let me know.