MLB showdown

[BenBrostoff]

Note - work in progress

Left to do:

• Deploy new version
• Add documentation
• Add repl.it showdown example

[BenBrostoff]

@sharkiteuthis Not sure if you wrote this piece but assuming this change was the intent?

[sharkiteuthis]

__contains__() is supposed to return a boolean, I think this change will break NFL if the string comparison short circuit doesn't return true

[BenBrostoff]

I think the issue here is p was out of scope originally. Maybe this?:

    def __contains__(self, player):
        if isinstance(player, str):
            for p in self.players:
                if p.name == player or p.short_name == player:
                    return True
        elif isinstance(player, Player):
            return player in self.players
        else:
            raise NotImplementedError

[BenBrostoff]

This is an issue I think for all the other showdown games. It at least impacts the display if CPT isn't a constraint here - everything shows as FLEX.

[sharkiteuthis]

yeah, i think NHL showdowns are broken or at least non-optimal right now. Look at get_nfl_showdown_positions or NBA_SHOWDOWN rules

[BenBrostoff]

I think this is a change we want. I question hard-coding a 1.5 - the drawback I guess is that the rules of DraftKings are no longer "exposed" anywhere - but if we are going to expose them, it should be done as something you can pass into the initializer or maybe in RuleSet.

[sharkiteuthis]

I thought per #140 the CSVs provided by DK include CPT entires?

[BenBrostoff]

They do - I think I want to keep ShowdownPlayer though since real_pos is valuable and used by the optimizer. EDIT - so in that sense the CSV exposes the rules, but it's still a little tricky since I don't know that everybody who uses this library decides to directly ingest the CSV. I do though so it's good enough for me now :-).