Convert to pip module #90
Conversation
|
let me know when you want me to review |
|
Will do, this might take a few days because the API is changing in a significant way. |
|
What are these items?
Do you mind explaining what you have in mind here? Is there overlap with #94? |
|
Ah that’s my fault, I didn’t see 94. The flex is overlap but the rules just
refer to objects that contain data on salary cap / roster size / etc based
on the sport and site. The custom function is a way to filter the players
by some arbitrary condition like has an average of at least 10 points or is
on the Clippers but is not a PG.
…On Tue, Nov 27, 2018 at 11:47 AM Tom Dodson ***@***.***> wrote:
What are these items?
- Expose rules
- Allow option to control flex position (blacklist or whitelist)
- Allow user to pass in custom functions for player pool
Do you mind explaining what you have in mind here? Is there overlap with
#94 <#94>?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGqt9J_oAkFEWJeCe9i9y7lr6iOiMRrDks5uzXqggaJpZM4YyGv0>
.
|
|
I like the rules idea. In general I don't stack QB/RB unless it's Dak/Zeke, Jackson/Edwards, or Cam/CMC. It would be cool to handle that with a single rule instead of having to write 29 groups |
BenBrostoff
force-pushed
the
feature/pip
branch
from
871343f
to
50f6f10
Compare
There was a problem hiding this comment.
Can you create issues for:
- uploading CSVs to DraftKings / FanDuel and 2) exposure work you completed (it's there actually but not documented or tested) and 3) pick em optimizer for DraftKings.
You can assign (2) to me.
I'll change my RuleSet and Rule classes on my WIP branch to something like BuildRules or LineupRules to avoid confusion with the DK/FD game ruleset. That's a more accurate classname anyway.
I'm also seeing a syntax error when I run tests locally:
File "/dk/draftfast/__init__.py", line 1, in <module>
from draftfast import (
File "/dk/draftfast/optimize.py", line 8, in <module>
from draftfast.rules import RuleSet
File "/dk/draftfast/rules.py", line 25
'NFL': 50_000,
^
SyntaxError: invalid syntax
----------------------------------------------------------------------
Ran 1 test in 0.497s
| league='NHL', | ||
| roster_size='9', | ||
| position_limits=[['C', 9, 9]], | ||
| salary_max=50_000, |
There was a problem hiding this comment.
I get a syntax error here
| } | ||
|
|
||
|
|
||
| SALARY_CAP = { |
|
@sharkiteuthis Ugh, this is a Python 3.5 thing. I'm upgrading the |
|
Also the Travis build is no longer triggering. I think this is related to them deprecating travis-ci.org... not worrying about it for now. |
|
Okay @sharkiteuthis , once you approve this I'll merge in 👍 . Added the issues you mentioned. |
|
building the new docker image, numpy takes forever on my laptop |
|
works for me |
This PR will address #63 . I've published a version (
1.0.0) to pip. I'm putting my TODO list here so people can follow along as this gets developed:Namespace/ CLI stuffNot completed, okay to move to issues:
@sharkiteuthis -
this isn't ready yet but I'm hoping to finish in the next few days. If you're working on other branches it may be useful to periodically pull from this branch.I've released1.0.0and even though this is a little rough around the edges, I think we should merge to master so working on feature branches is easier. The three things that are core functionality that are not in the exposed library right now are 1) uploading CSVs to DraftKings / FanDuel and 2) exposure work you completed (it's there actually but not documented or tested) and 3) pick em optimizer for DraftKings. I can create issues for all three.I invited you to the repo so you can have review access - let me know if you didn't get it 👍
UPDATE - you can experiment with the exposed module on repl.it here