Feature/add api endpoints #11

Benawi · 2023-09-15T09:55:56Z

Implemented Features

General requirements

Make sure that there are no linter errors.
Make sure that you used the correct Gitflow.
Make sure that you documented your work in a professional way.

Ruby requirements

Follow our list of best practices for Ruby.

Project requirements

Create an API endpoint to list all posts for a user.
Create an API endpoint to list all comments for a user's post.
Create an API endpoint to add a comment to a post. Remember that the owner of the comment is the user that makes it; it should not be set by passing a parameter.
Your API endpoints should receive JSON and respond JSON as well.

…ture/add_API_endpoints

joskalenda

STATUS: REQUIRED CHANGES ♻️
Hi @Benawi ,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

[ ]... ✅ Great readme file
[ ].. ✅ Green linters
[ ].... ✅ Api routes

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me(@joskalenda) in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

joskalenda · 2023-09-15T11:18:24Z

config/routes.rb

Nice routes implemented but am not able to log in as the confirmation path has a bug, see this image below to understand more, there is a line in the confirmation controller that prevents it from working, make sure you follow the devise docs for fixing this

Benawi · 2023-09-15T12:22:44Z

changes ♻

Routing bugs fixed

HAMMAS-SALEEM

Required Changes ♻️

Hey @Benawi. @wolterbwambale 👋

Highlights 🥇

✔️ Descriptive PR Title
✔️ Descriptive PR Summary
✔️ Following Gitflow
✔️ Following some requirements
✔️ Great work on fixing the bug previous reviewer find 👍

Good job on implementing some of the requirements, There are some issues that you still need to work on to go to the next project but you are almost there! 😊

Optional

All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

HAMMAS-SALEEM · 2023-09-15T14:29:57Z

app/controllers/api/comments_controller.rb

+  def create
+    @comment = Comment.new(
+      text: comment_params[:text],
+      users_id: comment_params[:users_id]
+    )
+    if @comment.save
+      @comment.update_post_comments_counter
+      render json: @comment, status: :created
+    else
+      render json: { errors: @comment.errors.full_messages }, status: :unprocessable_entity
+    end
+  end


Great work so far dear but i think there is a problem in your creating the comment api endpoint 😨 Because i cannot create any comment in your app 😨 I can see that you are creating a comment but you didn't include post_id in that comment object 🤔 I don't think you can create a comment without having an post_id 👍

It would be nice if you check in the rails console that you don't have any name such as user_id but you have a author_id so far i have observed 🤔 Kindly fix this issue as well 👍 Kindly make your app work as expected 👍

HAMMAS-SALEEM · 2023-09-15T14:34:08Z

app/controllers/api/posts_controller.rb

+  def index
+    @posts = Post.all
+    render json: @posts
+  end


Great work on implementing the post API 👍 but i guess misunderstood the requirement which was to get all the posts for a user means you are supposed to get all the posts of a user which is mentioned in the URL but you are getting posts of all the users at once 🤔 Kindly fix this issue to make your app follow the project requirements 😊

HAMMAS-SALEEM · 2023-09-15T15:00:57Z

app/controllers/api/comments_controller.rb

+class Api::CommentsController < ApplicationController
+  def index
+    @comments = Comment.all
+    render json: @comments
+  end
+


Great work on implementing the comments API 👍 but again same thing here you are supposed to get the comments for that specific post_id which you have in your URL and it is also mentioned in the project requirements 😊

HAMMAS-SALEEM · 2023-09-15T15:05:08Z

app/controllers/api/comments_controller.rb

+      render json: { errors: @comment.errors.full_messages }, status: :unprocessable_entity
+    end
+  end
+


It would be nice if you fix the highlihgted link in the Table of Contents to make your readme descriptive and profes

HAMMAS-SALEEM · 2023-09-15T15:05:16Z

app/controllers/api/comments_controller.rb

+      render json: { errors: @comment.errors.full_messages }, status: :unprocessable_entity
+    end
+  end
+


[OPTIONAL BUT HIGHLY RECOMMENDED]

It would be nice if you make your own logo of your name and put that in the readme file at the top to present yourself as a brand in the job market or tech industry to catch the recruiters' eyes 👍

HAMMAS-SALEEM · 2023-09-15T15:05:46Z

app/controllers/api/comments_controller.rb

+      render json: { errors: @comment.errors.full_messages }, status: :unprocessable_entity
+    end
+  end
+


NOTE FOR SENIOR REVIEWERS

I am making this review as a first review because the senior reviewer allowed me to make this review as a first review because the previous review had a lot of missing things so it would be nice if i make it as a first review 👍

Benawi · 2023-09-15T16:19:12Z

Changes ♻

Add load_and_authorize_resource to get user-based comments and posts
Add post_Id to comment create method
Amend user_id to author_id
Update reamefile

joskalenda

STATUS: APPROVED ✅
Hi @Benawi , 🥰
Your project is complete! There is nothing else to say other than... it's time to merge it Congratulations! 🎉

Highlights

✅ ... Api routes well implemented
✅ ... Green linters

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me(@joskalenda) in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Benawi and others added 9 commits September 15, 2023 12:14

Create an API endpoint to list all posts for a user

8c7e574

Create an API endpoint to comments

acf156f

add api into route

57d0176

add api post

d919be2

add comments in route resources

d33a65d

merge

68753fe

Merge branch 'develop' of https://github.com/Benawi/Blog-App into fea…

d71b2ca

…ture/add_API_endpoints

receive JSON and respond JSON as well.

3315f66

fix linters error

9ce8d57

Benawi assigned Benawi and wolterbwambale Sep 15, 2023

Benawi added the enhancement New feature or request label Sep 15, 2023

joskalenda suggested changes Sep 15, 2023

View reviewed changes

fix routing bugs

5b74505

HAMMAS-SALEEM suggested changes Sep 15, 2023

View reviewed changes

Benawi added 4 commits September 15, 2023 18:57

Add post id for creating of comment api endpoint

4a05c8d

Add load_and_authorize_resource to get user based posts

2bf8b2b

Update readme file

fd18de5

Update readme file

552638e

joskalenda approved these changes Sep 15, 2023

View reviewed changes

Benawi merged commit a4bfcfe into develop Sep 15, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/add api endpoints #11

Feature/add api endpoints #11

Benawi commented Sep 15, 2023

joskalenda left a comment

joskalenda Sep 15, 2023

Benawi commented Sep 15, 2023

HAMMAS-SALEEM left a comment

HAMMAS-SALEEM Sep 15, 2023

HAMMAS-SALEEM Sep 15, 2023

HAMMAS-SALEEM Sep 15, 2023

HAMMAS-SALEEM Sep 15, 2023

HAMMAS-SALEEM Sep 15, 2023

HAMMAS-SALEEM Sep 15, 2023

Benawi commented Sep 15, 2023

joskalenda left a comment

Feature/add api endpoints #11

Feature/add api endpoints #11

Conversation

Benawi commented Sep 15, 2023

General requirements

Ruby requirements

Project requirements

joskalenda left a comment

Choose a reason for hiding this comment

Highlights

Required Changes ♻️

Optional suggestions

Choose a reason for hiding this comment

Benawi commented Sep 15, 2023

changes ♻

HAMMAS-SALEEM left a comment

Choose a reason for hiding this comment

Required Changes ♻️

Hey @Benawi. @wolterbwambale 👋

Highlights 🥇

Optional

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NOTE FOR SENIOR REVIEWERS

Benawi commented Sep 15, 2023

Changes ♻

joskalenda left a comment

Choose a reason for hiding this comment

Highlights

Optional suggestions

Cheers and Happy coding!👏👏👏