Feature/controllers specs #5
Conversation
There was a problem hiding this comment.
Hi @Benawi ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✅ Professional documentation
Required Changes ♻️
Check the comments under the review.
Optional suggestions
- 🚀 Fantastic job on the pull request! 👏 However, I've noticed that there are some changes that were supposed to be made earlier on your
Comments migrationYour code migration appears solid, but I've come across a minor issue 🕵️♂️. The first two columns,author_idandpost_id, should actually be foreign keys, and interestingly, they are already defined as such in the last two columns. This oversight might lead to migration issues 😬. Let's streamline the process! 💪 I suggest we remove the linest.bigint :author_idandt.bigint :post_idsince they are already designated as foreign keys in the last two columns. This adjustment will ensure a smooth migration process 🛠️. Additionally, please review yourlikesmigration for a similar pattern and make the necessary corrections. Keep up the fantastic work! 🌟
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| require 'rails_helper' | ||
|
|
||
| RSpec.describe 'Users', type: :request do | ||
| describe 'GET /users' do | ||
| before :each do | ||
| get users_path | ||
| end | ||
|
|
||
| it 'should work!' do | ||
| expect(response).to have_http_status(200) | ||
| end | ||
|
|
||
| it 'renders template correctly' do | ||
| expect(response).to render_template(:index) | ||
| end | ||
|
|
||
| it "doesn't renders template other than /users" do | ||
| expect(response).to_not render_template(:show) | ||
| end | ||
|
|
||
| it 'shows the correct placeholder text' do | ||
| expect(response.body).to include('User was successfully created.') | ||
| end |
There was a problem hiding this comment.
- There are some failing tests. Please address them.
Changes ♻️
|
There was a problem hiding this comment.
Hi @Benawi ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
✅ Good work updating your migration files
Optional suggestions
N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Implemented Features
General requirements
Ruby requirements
Project requirements