Feature/integ specs views #8
Conversation
…/Blog-App into feature/Integ_Specs_Views
There was a problem hiding this comment.
STATUS: CHANGES REQUIRED
Hi @Benawi ,
Good job so far!
To Highlight! 👏 🟢
✔️ Collaborative work 👍 Commits from both team members
✔️ Screenshots of N + 1 solution attached to PR description
✔️ Has Capybara gem in Gemfile for integration test
✔️ Most test cases added
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -47,14 +38,4 @@ | |||
| it 'Pagination' do | |||
| expect(page).to have_button('Pagination') | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
- Great job working on this milestone. You are currently missing the test that
redirects to the post's show page when you click on a post.
| it 'displays each post with relevant information' do | ||
| @posts = user.posts | ||
|
|
||
| @posts.each do |post| | ||
| expect(page).to have_content(post.title) |
There was a problem hiding this comment.
- You are currently missing:
- Test that asserts you can see the number of posts the user has written.
- Test that asserts you can see a post's title.
- Test that asserts you can see some of the post's body.
Kindly add the missing tests
| ) | ||
| end | ||
| visit user_posts_path(user) | ||
| end | ||
|
|
||
| it 'displays user profile information' do |
There was a problem hiding this comment.
- You are currently missing the following tests:
- Test that asserts you can see the user's profile picture.
- Test that asserts you can see the user's username.
Kindly add these missing test cases
| @@ -1,7 +1,7 @@ | |||
| require 'rails_helper' | |||
|
|
|||
| RSpec.describe 'Post show page', type: :feature do | |||
| let!(:user) { User.create(name: 'Sarkodie', photo: '/path/to/photo1.jpg', post_counter: 10) } | |||
| let!(:user) { User.create(name: 'Sarkodie', photo: 'https://unsplash.com/photos/F_-0BxGuVvo', posts_counter: 10) } | |||
| let!(:post) do | |||
| Post.create( | |||
There was a problem hiding this comment.
- At the moment you are missing the test that asserts that you can see who wrote the post. Kindly add it.
| @@ -25,12 +25,6 @@ | |||
| end | |||
| end | |||
|
|
|||
| it 'displays the number of posts each user has written' do | |||
There was a problem hiding this comment.
- You are currently missing the following test:
- Test that asserts you can see the number of posts each user has written.
Kindly add the missing test case
Changes
|
There was a problem hiding this comment.
Status: Approved ✔️
Hi @Benawi
Your project is complete! Great job for making the requested changes🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 
. Congratulations! 🎉💯🌟
Good Points 👍
✔️Descriptive Pull Request
✔️ Screenshots of N + 1 solution attached to PR description
✔️ Has Capybara gem in Gemfile for integration test
✔️ test cases added
✔️No linter errors
Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.
Implemented Features
General requirements
Ruby requirements
Project requirements
Make sure that the N+1 problem is solved when fetching all posts and their comments for a user.
include the screenshots of your app's logs before and after the fix
before
after
-[x] Integration specs