Feature/add devise #9
Conversation
… into feature/Add_devise
There was a problem hiding this comment.
Hi @Benawi,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Repo uses a professional readme template as required
- Devise added as a gem and configured properly in the app
- A user can register, authenticate, and their password is encrypted via devise gem
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- x
- y
- z
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Find me on slack
Martin Afani
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
app/models/user.rb
Outdated
| # Include default devise modules. Others available are: | ||
| # :confirmable, :lockable, :timeoutable, :trackable and :omniauthable | ||
| devise :database_authenticatable, :registerable, | ||
| :recoverable, :rememberable, :validatable |
There was a problem hiding this comment.
- Please allow users to confirm their emails by adding
:confirmableto thedeviseline
|
Changes ♻️
|
There was a problem hiding this comment.
Hi Team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✅ Good work adding :confirmable to your user model 👍
Required Changes ♻️
Check the comments under the review.
Optional suggestions
N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| devise :database_authenticatable, :registerable, | ||
| :recoverable, :rememberable, :validatable, :confirmable | ||
| # Include default devise modules. Others available are |
There was a problem hiding this comment.
- Hey there! 🚀 Great effort on updating the User model with
:confirmable, but it seems there's a missing piece. 😅 Without a corresponding migration, the database won't reflect these changes, which can lead to issues.
To help you out
- I found a fantastic resource 📺 that walks you through adding
:confirmableto your Devise User model and creating the necessary migration. Check out this video tutorial: Adding Confirmable to Devise User Model. It should guide you through the process step by step.
Keep up the good work, and don't hesitate to ask if you have any questions along the way! 🌟💡😊
Changes ♻
|
There was a problem hiding this comment.
Hi @Benawi,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
To Highlight
- Correct use of GitFlow ✔️
- Descriptive commit messages ✔️
- Professional looking pull request ✔️
- Your readme looks professional ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Implemented Features
General requirements
Ruby requirements
Project requirements