Remove simulated data from tip 4 and change tip 5 to focus on reproducibility #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I removed a paragraph which is essentially links to three different rules. |
cgreene
approved these changes
Oct 18, 2020
|
Changes look good to me. I can't remember where that simulation ended up coming from initially but it has been moved all over the full manuscript. Maybe it's rule 11, which doesn't quite make a ten simple rules list :) |
pstew
approved these changes
Oct 20, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
[ci skip] This build is based on b0b80ef. This commit was created by the following CI build and job: https://github.com/Benjamin-Lee/deep-rules/commit/b0b80ef657f8f53769a02e1d476a8bdcc2c429f3/checks https://github.com/Benjamin-Lee/deep-rules/runs/318694289
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
[ci skip] This build is based on b0b80ef. This commit was created by the following CI build and job: https://github.com/Benjamin-Lee/deep-rules/commit/b0b80ef657f8f53769a02e1d476a8bdcc2c429f3/checks https://github.com/Benjamin-Lee/deep-rules/runs/318694289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you add yourself as a contributor if this is your first contribution?
Any more details?
This PR addressed two issues:
When addressing (2), I noticed that Tip 5 was really about reproducibility, especially since we talk about training complexity in the first tip now. I also saw this paper (https://www.nature.com/articles/s41586-020-2766-y) earlier today, which made me think we should address code sharing as distinct from data sharing.