fix uid generation and usage #1
Conversation
| @@ -32,7 +32,7 @@ namespace alpaka | |||
| namespace detail | |||
| { | |||
| //############################################################################# | |||
| // Based on the code from Filip Ros�en at http://b.atch.se/posts/constexpr-counter/ | |||
| // Based on the code from Filip Ros�en at http://b.atch.se/posts/constexpr-counter/ | |||
There was a problem hiding this comment.
Could you replace the '�' with a simple 'e'?
There was a problem hiding this comment.
ohh yes. We should encode all files with plain ascii and not with UTF8. There are some compiler were we get problems with UTF8:-(
psychocoderHPC
force-pushed
the
fix-shared-alloc-onHost
branch
from
bbf0b35
to
3daac37
Compare
| @@ -108,7 +108,7 @@ namespace alpaka | |||
| auto constexpr reader( | |||
| float, | |||
| flag<N>, | |||
| std::size_t R = reader(std::size_t{0u}, flag<N-1u>{})) | |||
| std::size_t R = reader(std::size_t(0), flag<N-1u>())) | |||
There was a problem hiding this comment.
What is the advantage of using paranthesis versus the brackets?
There is a semantic difference. Your version is a cast while my version fails compilation if the value is not exactly representable by the given type. However, in this case there is no difference for the flag constructor.
There was a problem hiding this comment.
I think I changed it because it not compile with {} but I will check it again.
psychocoderHPC
force-pushed
the
fix-shared-alloc-onHost
branch
from
3daac37
to
4d5dda4
Compare
- add id call to function `allocVar` and `allocArr` - `UniqueId.hpp` - use `#if" instead of `#ifdef` to check the compiler - use signed value for array declaration - enable declaration of `flag<>` and `adl_flag<>()`
psychocoderHPC
force-pushed
the
fix-shared-alloc-onHost
branch
from
4d5dda4
to
ebdc922
Compare
|
I changed
|
fix uid generation and usage
Add unit tests for template argument deduction in kernels
allocVarandallocArrUniqueId.hpp#if" instead of#ifdef` to check the compiler