Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong biome set after island deletion #1513

Closed
piotrskibapl opened this issue Aug 30, 2020 · 3 comments
Closed

Wrong biome set after island deletion #1513

piotrskibapl opened this issue Aug 30, 2020 · 3 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug

Comments

@piotrskibapl
Copy link

Description

Describe the bug

For a few weeks I've been investigating an issue with some players having other biome (plains) set on the island instead of the one in the config. I found out that it's caused by the island deletion - whenever player resets his island or his island gets deleted, the biome would be set to plains instead of the one set in the addon config.

Steps to reproduce the behavior

Precondition: set "default-biome" option in the config to any biome other than plains and delete all worlds

  1. Create an island
  2. Delete it
    Observed: the deleted island area biome is set to the plains.

Expected behavior

The deleted island area should be set to the biome from the config.

Environment

Output of /bbox version (Mandatory)
[01:39:19 INFO]: Running PAPER 1.15.2.
[01:39:19 INFO]: BentoBox Version: 1.14.2
[01:39:19 INFO]: Database: JSON
[01:39:19 INFO]: Loaded Game Worlds:
[01:39:19 INFO]: acid (Acid): World, Nether, The End
[01:39:19 INFO]: Loaded Addons:
[01:39:19 INFO]: AcidIsland 1.14.3-SNAPSHOT-b859 (ENABLED)
[01:39:19 INFO]: Challenges 0.8.3 (ENABLED)
[01:39:19 INFO]: ControlPanel 1.7.0 (ENABLED)
[01:39:19 INFO]: DimensionalTrees 1.6.0 (ENABLED)
[01:39:19 INFO]: Level 2.4.0 (ENABLED)
[01:39:19 INFO]: Limits 1.14.0 (ENABLED)
[01:39:19 INFO]: Warps 1.10.0 (ENABLED)

Additional context (Optional)

I'm experiencing this issue on AcidIsland, but I assume that the island deletion is universal for every addon so I created an issue there.

@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug labels Sep 1, 2020
@tastybento tastybento self-assigned this Sep 1, 2020
@tastybento
Copy link
Member

I can replicate this. Looking at why this is happening.

@tastybento tastybento added Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Sep 1, 2020
@tastybento
Copy link
Member

The shift to 3D biomes made this happen. Thanks for the report. Please confirm with the Snapshot build when it's ready.

@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Sep 1, 2020
@piotrskibapl
Copy link
Author

It works well with the latest snapshot. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants