Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invswitcher not working right(boxed) #26

Closed
6008417 opened this issue Apr 27, 2021 · 2 comments
Closed

invswitcher not working right(boxed) #26

6008417 opened this issue Apr 27, 2021 · 2 comments
Assignees
Labels
bug Something isn't working done task has been completed

Comments

@6008417
Copy link

6008417 commented Apr 27, 2021

Description

Describe the bug

whenever I complete an advancement in the boxed world, I will recieve that advancement on the skyblock and oneblock world too.

Steps to reproduce the behavior

get into a boxed world get an advancement switch to skyblock
and back to boxed and then back to skyblock and boom you got the same advancement on skyblock even tho you didnt do anything in the skyblock world.

Expected behavior

keeping the advancements per world.

Screenshots and videos (Optional)


Environment

Output of /bbox version (Mandatory)

[12:28:42 INFO]: Running PAPER 1.16.5.
[12:28:42 INFO]: BentoBox version: 1.16.1
[12:28:42 INFO]: Database: JSON
[12:28:42 INFO]: Loaded Game Worlds:
[12:28:42 INFO]: boxed_world (Boxed): Overworld, Nether, The End*
[12:28:42 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[12:28:42 INFO]: oneblock_world (OneBlock): Overworld, Nether*
[12:28:42 INFO]: Loaded Addons:
[12:28:42 INFO]: AOneBlock 1.5.5 (ENABLED)
[12:28:42 INFO]: Bank 1.3.0 (ENABLED)
[12:28:42 INFO]: Biomes 1.14.0 (ENABLED)
[12:28:42 INFO]: Border 3.1.1 (ENABLED)
[12:28:42 INFO]: Boxed 1.1.4 (ENABLED)
[12:28:42 INFO]: BSkyBlock 1.14.4 (ENABLED)
[12:28:42 INFO]: Challenges 0.8.4 (ENABLED)
[12:28:42 INFO]: Chat 1.1.3 (ENABLED)
[12:28:42 INFO]: CheckMeOut 1.0.2 (ENABLED)
[12:28:42 INFO]: ControlPanel 1.13.0 (ENABLED)
[12:28:42 INFO]: DimensionalTrees 1.6.0 (ENABLED)
[12:28:42 INFO]: ExtraMobs 1.11.0.3 (ENABLED)
[12:28:42 INFO]: Greenhouses 1.5.3 (ENABLED)
[12:28:42 INFO]: InvSwitcher 1.9.1-SNAPSHOT-b189 (ENABLED)
[12:28:42 INFO]: IslandFly 1.8.1 (ENABLED)
[12:28:42 INFO]: Level 2.6.3 (ENABLED)
[12:28:42 INFO]: Likes 2.1.1 (ENABLED)
[12:28:42 INFO]: Limits 1.15.5 (ENABLED)
[12:28:42 INFO]: MagicCobblestoneGenerator 2.3.0 (ENABLED)
[12:28:42 INFO]: MagicSummon 1.5.0.0 (ENABLED)
[12:28:42 INFO]: TwerkingForTrees 1.4.1 (ENABLED)
[12:28:42 INFO]: Visit 1.3.0 (ENABLED)
[12:28:42 INFO]: VoidPortals 1.5.0.0 (ENABLED)
[12:28:42 INFO]: Warps 1.10.2 (ENABLED)```



#### Plugins (Optional)
<!-- Paste the `/plugins` output inside the code block below (remove the underscores). Do not provide an image. -->

[12:29:16 INFO]: Plugins (9): BentoBox, Essentials, EssentialsSpawn, FastAsyncWorldEdit (WorldEdit), LuckPerms, Vault, WorldBorderAPI, WorldGeneratorApi, WorldGuard

 
### Additional context (Optional)
<!-- Any additional information you'd like to provide us. -->
<!-- Please type below this line. -->

the version of invswitcher says 1.9.1 but that's bcs someone in the discord server told me to try the latest snapshot to see if it was fixed the problem is also 1.9.0.
@tastybento tastybento self-assigned this Apr 28, 2021
@tastybento tastybento transferred this issue from BentoBoxWorld/InvSwitcher Apr 28, 2021
@tastybento tastybento added bug Something isn't working in progress task is actively being worked on labels Apr 28, 2021
@tastybento
Copy link
Member

This looks like it's actually a bug with Boxed and the syncing of advancements on teleportation. It needs more debugging but I'm moving it to Boxed because I think InvSwitcher is not the issue here.

tastybento added a commit that referenced this issue Apr 29, 2021
When teleporting, the advancements were synced before the teleport
completed. This uses a different event.

#26
@tastybento tastybento added done task has been completed and removed in progress task is actively being worked on labels Apr 29, 2021
@tastybento
Copy link
Member

See the latest release for this fix. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done task has been completed
Projects
None yet
Development

No branches or pull requests

2 participants