Implement missing config options. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TeamJoinEvent listener that checks if TeamJoinDeathReset is enabled and resets player death count.
Improved calculating death penalty. Death count now checks if it must include teamDeaths. maxDeaths now is working, as deathHandicap will be set to minimal value from it and current deathCount. Change level and pointsToNextLevel calculation. Now it will remove deathCount * deathPenalty points from rawBlockCount and use new value to calculate current level and points till next one.
Poslovitch
requested changes
Jan 2, 2019
|
@Poslovitch I think this is the correct place for this. The death calculations are all specific to this add-on. |
tastybento
approved these changes
Jan 3, 2019
|
Okay I see that some changes were made. Right now this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add missing config option usage.
I implement sumTeamDeaths, maxDeaths and deathPenalty options.
It was necessary to change level calculation. Now it will calculate deathHandicap based on sumTeamDeaths and maxDeaths values. To implement deathPenalty I introduce a local variable that is calculated based on rawBlockCount and deathPenalty and use this variable to calculate level and points till next level.