-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple example #4
Conversation
/VerifAI/examples/webots/controllers/verifai_supervisor$ python verifai_falsifier.py It seems to work, but slightly there is small.
|
I think I need to clean up and try to be closed to be you guys coding style. |
Sorry I find "Unsafe samples: Error table, Empty DataFrame" comes from last code of verifai_falsifier.py
In any case, I wonder if you could check that works correctly. |
Hi,
Thank you for your email. :)
The reason you are getting the error is because there are no
counterexamples. Notice all the samples have positive rho, and hence safe.
The empty data frame implies that there are no counterexamples and hence the
table is empty.
Best,
Shromona
…On Wed, May 8, 2019 at 11:58 AM TomyYamy ***@***.***> wrote:
Sorry I find "Unsafe samples: Error table, Empty DataFrame" comes from
last code of verifai_falsifier.py
print("Unsafe samples: Error table")
print(falsifier.error_table.table)
In any case, I wonder if you could check that works correctly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADIEAVSHY3OMQPYYQU7LZPDPUMPDRANCNFSM4HLS6N7Q>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would like scenic to be installed during setup. Commenting it will not allow it.
So now it works well. so I'll clean up the code from now. |
Applying SCENIC itself OK. However I think we had better to split example also as a unit testing. How about implementing Webot+Falsifcation(=sample input+STL), Webot+Falsification(=sample SENIC+STL) separately? |
Hi,
Webot+Falsifications (no scenic) is already available in the
cones_lanechange_supervisor
In the present release, scenic is used for scene generation only. We are
now currently hooking that up to the falsifier loop and will let you know
when it’s available.
Best,
Shromona
…On Thu, May 9, 2019 at 12:19 PM TomyYamy ***@***.***> wrote:
Applying SCENIC itself OK.
However I think we had better to split example also as a unit testing.
Too much integrated example is difficult to understand user at first time.
How about implementing Webot+Falsifcation(=sample input+STL),
Webot+Falsifcation(=sample SENIC+STL)?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADIEAVWM4Q7FEWXP2XIT7ATPUR2MZANCNFSM4HLS6N7Q>
.
|
Yes, cones_lanechange_supervisor is Webot+Falsifications (no scenic) . In other word, |
SCENIC implementation is interesting. So you means, previously SCENIC worked as a sampler or optimizer class, now your are trying to run at the insides of as a model or target side. I think good idea. In addition, We suffered setting of pre-condition constraint and sometimes preconditions become complex and difficult to find SAT case of those. |
I see, I do have an example like that, I can push it for you :)
…On Thu, May 9, 2019 at 4:50 PM TomyYamy ***@***.***> wrote:
Yes, cones_lanechange_supervisor is Webot+Falsifications (no scenic) .
but little bit complex to 1st step because it needs setting up tensorflow,
opencv and PIL. Sometimes user fail to setup those (mainly tensorflow...).
In other word,
cones_lanechange_supervisor = Webot(=Webot+tensorflow) +
Falsifcation(=sample input+STL),
and my suggestion is
simple example = Webot + Falsifcation(=sample input+STL).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADIEAVQCOLFWEP2YMD5QO53PUS2FZANCNFSM4HLS6N7Q>
.
|
That's good! Thank you. |
I have made a very simple example by using /user/local/Webots/projects/languages/python/worlds/example.wbt
at simpleExample branch.
I checked it on Python3.6 & Webots 2018 & ubuntu18.04