[Fix] Graceful rejection of token input for AWS Embeddings API #1685
Conversation
|
This PR is being deployed to Railway 🚅 litellm: ◻️ REMOVED |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
litellm/llms/bedrock.py
Outdated
| @@ -702,6 +702,11 @@ def _embedding_func_single( | |||
| encoding=None, | |||
| logging_obj=None, | |||
| ): | |||
| if type(input) != str: | |||
There was a problem hiding this comment.
@rmann-nflx doing the check here as opposed to 810, because on 810 we'd have to loop through all elements in the list and assert none of them are str
There was a problem hiding this comment.
Makes sense -- much cleaner approach imho
| model="amazon.titan-embed-text-v1", | ||
| input=[1], | ||
| ) | ||
|
|
There was a problem hiding this comment.
added your unit test to our ci/cd @rmann-nflx
litellm/llms/bedrock.py
Outdated
| @@ -702,6 +702,11 @@ def _embedding_func_single( | |||
| encoding=None, | |||
| logging_obj=None, | |||
| ): | |||
| if type(input) != str: | |||
There was a problem hiding this comment.
Heads up, I think this needs to be:
if isinstance(input, str) is False:
...
If you inherit from str then this rejects when I think it would be valid for it to work:
Example:
class CustomStr(str):
pass
def test_lower_str():
x = CustomStr("x")
assert x == "x"
assert x != "y"
assert type(x) != str
assert isinstance(x, str)
This is a toy example, but I have seen stuff like this in the wild to constrain str to known patterns
|
will merge once main is stable |
Bedrock Embeddings API for accepts only str | List[str].