implement /get-friends route #151
Conversation
RafaelPiloto10
requested review from
brendacano,
MimiOlayeye and
oreorz
as code owners
|
is this ready for review? |
| @@ -14,9 +14,10 @@ def token_response(token: str): | |||
| "access_token": token | |||
| } | |||
|
|
|||
| def signJWT(user_id: str) -> Dict[str, str]: | |||
| def signJWT(user_id: str, email: str) -> Dict[str, str]: | |||
There was a problem hiding this comment.
I think you don't have to include email in JWT token, but it's also fine if you do.
There was a problem hiding this comment.
I agree -- I think UUID is the more important one. Currently, the JWT only stores the email, so this comment is a little misleading. I am moving the email to a separate parameter and adding UUID as the new first parameter as we care about that one more. Should we get rid of email in it's entirety?
| friends = [] | ||
| for friend_email in user["friends"]: | ||
| fu = db.get_user_by_email(friend_email) | ||
| friends.append(json.loads(json_util.dumps(fu))) |
There was a problem hiding this comment.
We can optimize this later by having a single batch query. For now, this is good.
There was a problem hiding this comment.
Do you know the method off the top of your head? I forgot we could do that. I can do some research tomorrow otherwise
yes, I'll add the label, thanks :D |
No description provided.