dev-to-prod #2203
Merged
dev-to-prod #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: hide intercom (#2190) * [dev] Move logout to ProfilePage * dev: logout translations
* dev: stiicky header * dev: article mobile padding
* dev add images * dev: change images sources
|
Important Please set a versioning label of either |
jonsnowpt
approved these changes
Jun 19, 2024
[1] ──── Removal of unecessary redundant assets for MACOSX that are used no where in the project.
migbash
reviewed
Jun 19, 2024
| @@ -50,24 +51,46 @@ | |||
| tablet && !mobile | |||
| ? ["changelog", "about", "roadmap", "status", "terms", "privacy"] | |||
| : ["changelog", "status", "about", "terms", "roadmap", "privacy"]; | |||
| $: isDesktop = $sessionStore.viewportType === "desktop"; | |||
There was a problem hiding this comment.
Unecessary line, project preference is to use:
$: ({ viewportType } = $sessionStore);
[..]
<footer
class:mobile
class:desktop={viewportType === 'desktop'}
class="dark-mode"
>
PS: You've already done it (almost) correctly in line: 60 :: {#if $sessionStore.viewportType !== "mobile"} 😁
migbash
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of icons, thats why it contains 537 files changes
Please
click onthe(^) Previewtab and select the appropriate sub-template: