Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplecov as a development dependency #434

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

kdiogenes
Copy link
Contributor

Without simplecov bundle exec rspec gives a bunch of errors like:

An error occurred while loading ./spec/better_errors/code_formatter_spec.rb.
Failure/Error: require 'simplecov'

LoadError:
  cannot load such file -- simplecov
# ./spec/spec_helper.rb:16:in `require'
# ./spec/spec_helper.rb:16:in `<top (required)>'
# ./spec/better_errors/code_formatter_spec.rb:1:in `require'
# ./spec/better_errors/code_formatter_spec.rb:1:in `<top (required)>'

@RobinDaugherty RobinDaugherty merged commit 39b3168 into BetterErrors:master Feb 11, 2019
@RobinDaugherty
Copy link
Member

Thanks for your contribution @cerdiogenes!

Simplecov (through Coveralls) is already included in each of the Gemfiles, where require: false can be used. This is required in order to have simplecov work correctly—it needs to be required at the top of spec_helper, and must not be loaded by Bundler before that.

I made this change while merging this PR.

@RobinDaugherty RobinDaugherty changed the title Adds simplecov as a development dependencie Add simplecov as a development dependency Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants